Skip to content

UI: Masonry layout for widgets#2845

Closed
da-Kai wants to merge 15 commits intoOpenEMS:developfrom
da-Kai:feature/ui-dev/widgets-masonry
Closed

UI: Masonry layout for widgets#2845
da-Kai wants to merge 15 commits intoOpenEMS:developfrom
da-Kai:feature/ui-dev/widgets-masonry

Conversation

@da-Kai
Copy link
Contributor

@da-Kai da-Kai commented Oct 18, 2024

Aktuell

Bildschirmfoto am 2024-10-18 um 18 02 25

Masonry Layout

Bildschirmfoto am 2024-10-18 um 18 01 06

@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (4.77%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2845      +/-   ##
=============================================
+ Coverage      58.84%   58.85%   +0.01%     
  Complexity       173      173              
=============================================
  Files           2619     2619              
  Lines         113026   113046      +20     
  Branches        8317     8319       +2     
=============================================
+ Hits           66494    66517      +23     
+ Misses         44039    44038       -1     
+ Partials        2493     2491       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@da-Kai
Copy link
Contributor Author

da-Kai commented Oct 25, 2024

@lukasrgr
Ich hab die Implementierung jetzt so geändert, dass die reihenfolge gleich bleibt

openems-masonry

@Sn0w3y
Copy link
Collaborator

Sn0w3y commented Nov 15, 2024

Just a little Information for you @da-Kai - I tried this and it basically scrumbled up sometimes all Widgets as they got rendered too slow because of the slower Channel Population of some Components - either we need to increase the Timeout here:

https://github.com/OpenEMS/openems/pull/2845/files#diff-b001e10dc95932dfad86e0e988df71e34fafc7fa94c3457d65707af3d19f8a07R49

or find another solution for it i guess ? :)

Edit: The CSS does not get applied correctly if the Container is getting bigger after Channel Population. This leads to Overlapping Cards for example. I also got it from time to Time, that the Cards were just above each other on the top left upper corner, where nothing could be seen anymore. JFYI

Greetings !

Copy link
Contributor

@lukasrgr lukasrgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not approve it like this

@da-Kai
Copy link
Contributor Author

da-Kai commented May 31, 2025

Hi @Sn0w3y,
If you don't mind, could you test it again?

@Sn0w3y
Copy link
Collaborator

Sn0w3y commented May 31, 2025

Hi @Sn0w3y,
If you don't mind, could you test it again?

Sure, i already saw you changed things - will test it and Report as soon as I did - just had no time right now to do so :)

@sfeilmeier
Copy link
Contributor

@da-Kai This layout will become obsolete with the new navigation (see prototype in EVSE)

@Sn0w3y
Copy link
Collaborator

Sn0w3y commented May 31, 2025

@da-Kai This layout will become obsolete with the new navigation (see prototype in EVSE)

Hi Stefan, is there a Sneak-Peak available?

@sfeilmeier
Copy link
Contributor

@Sn0w3y It's still very much work-in-progress and no-UI/UX-designers-involved-yet, but these are two recent screenshots of the mobile App with a new multi-level, bottom navigation approach:

grafik

@da-Kai da-Kai closed this Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants